Skip to content

Conversation

toge
Copy link
Contributor

@toge toge commented Oct 16, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

https://github.com/caomengxuan666/libgossip/releases/tag/v1.1.2.0

@BillyONeal BillyONeal closed this Oct 16, 2025
@BillyONeal BillyONeal reopened this Oct 16, 2025
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

   Creating library libgossip_net.lib and object libgossip_net.exp
gossip_net_c.cpp.obj : error LNK2019: unresolved external symbol "class std::array<unsigned char,16> __cdecl to_cpp_node_id(struct gossip_node_id const *)" (?to_cpp_node_id@@YA?AV?$array@E$0BA@@std@@PEBUgossip_node_id@@@Z) referenced in function gossip_serializer_serialize
gossip_net_c.cpp.obj : error LNK2019: unresolved external symbol "struct libgossip::node_view __cdecl to_cpp_node_view(struct gossip_node_view const *)" (?to_cpp_node_view@@YA?AUnode_view@libgossip@@PEBUgossip_node_view@@@Z) referenced in function gossip_serializer_serialize
gossip_net_c.cpp.obj : error LNK2019: unresolved external symbol "struct gossip_node_id __cdecl to_c_node_id(class std::array<unsigned char,16> const &)" (?to_c_node_id@@YA?AUgossip_node_id@@AEBV?$array@E$0BA@@std@@@Z) referenced in function gossip_serializer_deserialize
gossip_net_c.cpp.obj : error LNK2019: unresolved external symbol "struct gossip_node_view __cdecl to_c_node_view(struct libgossip::node_view const &)" (?to_c_node_view@@YA?AUgossip_node_view@@AEBUnode_view@libgossip@@@Z) referenced in function gossip_serializer_deserialize
libgossip_net.dll : fatal error LNK1120: 4 unresolved externals
ninja: build stopped: subcommand failed.

Appears that the failures on this one are legitimate :/

@BillyONeal BillyONeal marked this pull request as draft October 17, 2025 18:03
@toge
Copy link
Contributor Author

toge commented Oct 19, 2025

@BillyONeal
Thank you for investigation.
I decided to drop support for windows shared build.
While to_cpp_node_id is defined in libgossip without being declared in header file,, gossip_serializer_serialize in libgossip_net refers to_cpp_node_id without dllexport.
Resolving this would require a relatively large fix in upstream.

@dg0yt
Copy link
Contributor

dg0yt commented Oct 19, 2025

Hm, doesn't it need to be fixed anyways? AFAIU it is a regression and should be reported as such upstream.

And removing support for dynamic Windows triplets is too much when you can do

if(VCPKG_TARGET_IS_WINDOWS)
    vcpkg_check_linkage(ONLY_STATIC_LIBRARY) # DLL broken in 1.1.2.0
endif()

@BillyONeal BillyONeal added the category:port-update The issue is with a library, which is requesting update new revision label Oct 20, 2025
@toge
Copy link
Contributor Author

toge commented Oct 22, 2025

@dg0yt
Thank you!
I update this PR and support UWP.
Please review it again.

@toge toge marked this pull request as ready for review October 22, 2025 13:27
+ target_link_libraries(
+ libgossip_net PRIVATE asio::asio
+ )
+ set_property(TARGET libgossip_net PROPERTY INTERFACE_LINK_LIBRARIES "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems strange to remove interface link libraries from asio::asio. Can you explain what this set_property is for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern I recognize is: A pure (header-only) build-time dependency, and the attempt to avoid the imported target in the exported link interface for static triplets.
The better way to to achive this is a generator expression in target_link_libraries, e.g. $<BUILD_INTERFACE:...>.

@BillyONeal BillyONeal added the info:reviewed Pull Request changes follow basic guidelines label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants