-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[libgossip] update to 1.1.2.0 #47830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Creating library libgossip_net.lib and object libgossip_net.exp
gossip_net_c.cpp.obj : error LNK2019: unresolved external symbol "class std::array<unsigned char,16> __cdecl to_cpp_node_id(struct gossip_node_id const *)" (?to_cpp_node_id@@YA?AV?$array@E$0BA@@std@@PEBUgossip_node_id@@@Z) referenced in function gossip_serializer_serialize
gossip_net_c.cpp.obj : error LNK2019: unresolved external symbol "struct libgossip::node_view __cdecl to_cpp_node_view(struct gossip_node_view const *)" (?to_cpp_node_view@@YA?AUnode_view@libgossip@@PEBUgossip_node_view@@@Z) referenced in function gossip_serializer_serialize
gossip_net_c.cpp.obj : error LNK2019: unresolved external symbol "struct gossip_node_id __cdecl to_c_node_id(class std::array<unsigned char,16> const &)" (?to_c_node_id@@YA?AUgossip_node_id@@AEBV?$array@E$0BA@@std@@@Z) referenced in function gossip_serializer_deserialize
gossip_net_c.cpp.obj : error LNK2019: unresolved external symbol "struct gossip_node_view __cdecl to_c_node_view(struct libgossip::node_view const &)" (?to_c_node_view@@YA?AUgossip_node_view@@AEBUnode_view@libgossip@@@Z) referenced in function gossip_serializer_deserialize
libgossip_net.dll : fatal error LNK1120: 4 unresolved externals
ninja: build stopped: subcommand failed. Appears that the failures on this one are legitimate :/ |
@BillyONeal |
Hm, doesn't it need to be fixed anyways? AFAIU it is a regression and should be reported as such upstream. And removing support for dynamic Windows triplets is too much when you can do if(VCPKG_TARGET_IS_WINDOWS)
vcpkg_check_linkage(ONLY_STATIC_LIBRARY) # DLL broken in 1.1.2.0
endif() |
@dg0yt |
+ target_link_libraries( | ||
+ libgossip_net PRIVATE asio::asio | ||
+ ) | ||
+ set_property(TARGET libgossip_net PROPERTY INTERFACE_LINK_LIBRARIES "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems strange to remove interface link libraries from asio::asio
. Can you explain what this set_property
is for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern I recognize is: A pure (header-only) build-time dependency, and the attempt to avoid the imported target in the exported link interface for static triplets.
The better way to to achive this is a generator expression in target_link_libraries
, e.g. $<BUILD_INTERFACE:...>
.
./vcpkg x-add-version --all
and committing the result.https://github.com/caomengxuan666/libgossip/releases/tag/v1.1.2.0