Skip to content

Conversation

EvilMcStevil
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

"license": null,
"supports": "(windows & !static) | osx | linux",
"dependencies": [
"blas",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this is the port which is to select the BLAS implementation. It is not a per-port choice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i noticed that, but something has changed since libtorch got accepted recently, and caused the linker to fail due to CRT/static/dynamic library linking. I suspect it is the blas implementation but trying to prove it is a multiple day long compile fest. Im trying to avoid fiddling with that can of worms until i have proven out other things.
Libtorchs prefered blas implementation is mkl and it will use that if found regardless of any others available, im just trying to prove compilation first to work out which platforms it correctly support before i just add it as a feature.

What does confuse me is why the linking has just started failing, without being picked up by the pipeline

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 47814 in repo microsoft/vcpkg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants