Build VSIX as non-prerelease #958
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the VSIX packaging step to omit the prerelease marker, allowing the extension to install on stable VS Code.
- Removed the
--pre-releaseflag from thevsce packagecommand. - Ensures the extension is treated as a non-prerelease build by default.
|
Though, maybe this is just a VS Code stable bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use typically insiders (which opts people in to prereleases by default), so I never noticed that attempting to install our extension pops up an error in regular VS Code:
Given we slap the word "preview" all over this extension, I think it would be better to not mark it as a prerelease, ensuring this error does not appear for the bulk of users.