Expose bind diags in LSP, show dead/deprecated code #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR surfaces bind errors in the LSP diagnostic stream and tags diagnostics marked as unnecessary or deprecated.
- Always include bind diagnostics alongside semantic diagnostics in
GetDocumentDiagnostics - Introduce
ReportsUnnecessary/ReportsDeprecatedflags onast.Diagnosticand emit LSP tags - Add
ptrToSliceIfNonEmptyhelper for optional slice pointers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/ls/diagnostics.go | Combined bind + semantic diagnostics, added diagnostic tags, and updated slice handling |
| internal/ast/diagnostic.go | Added boolean flags & accessors to propagate unnecessary/deprecated diagnostics |
Comments suppressed due to low confidence (1)
internal/ls/diagnostics.go:90
- Add or update unit tests to verify that diagnostics with
ReportsUnnecessaryandReportsDeprecatedproduce the correct LSP tags in the output.
Tags: ptrToSliceIfNonEmpty(tags),
gabritto
approved these changes
May 27, 2025
gabritto
reviewed
May 27, 2025
jakebailey
commented
May 27, 2025
| @@ -452,6 +456,39 @@ func (p *Program) getSemanticDiagnosticsForFile(ctx context.Context, sourceFile | |||
| return filtered | |||
| } | |||
|
|
|||
| func (p *Program) getSuggestionDiagnosticsForFile(ctx context.Context, sourceFile *ast.SourceFile) []*ast.Diagnostic { | |||
There was a problem hiding this comment.
This all is pretty duplicative but I'm not about to attempt to refactor it into some generic version, honestly.
gabritto
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #941