-
Notifications
You must be signed in to change notification settings - Fork 645
findAllReferences inital port #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ports the findAllReferences functionality and updates various components across the codebase. Key changes include:
- Adding new APIs and handlers (e.g. ResolveTripleslashReference in the path package and handleReferences in the LSP server) to support reference lookup.
- Replacing usage of older APIs (like GetAssignmentDeclarationKind) with new ones (GetJSDocAssignmentDeclarationKind) and renaming several utility functions for better export visibility.
- Introducing new testing files for findAllReferences and new core utilities (FlatMap and CoalesceList).
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
internal/tspath/path.go | Added ResolveTripleslashReference for triple-slash path resolution. |
internal/parser/reparser.go | Updated assignment declaration kind calls to use GetJSDocAssignmentDeclarationKind. |
internal/lsp/server.go | Added handling for ReferenceParams and a new handleReferences function. |
internal/ls/findallreferencesexport_test.go | New test file for export reference lookups. |
internal/ls/findallreferences_test.go | New tests covering various findAllReferences scenarios. |
internal/core/core.go | Introduced FlatMap and CoalesceList utility functions. |
internal/compiler/program.go | Added functions for module resolution improvements and extension handling. |
internal/checker/utilities.go | Renamed internal helper functions (e.g. HasModifier, GetSingleVariableOfVariableStatement). |
internal/checker/services.go | Added GetSymbolsOfParameterPropertyDeclaration for parameter-property handling. |
internal/checker/printer.go | Updated modifier check call in expression printing. |
internal/checker/exports.go | Added exported helper functions for type operations and symbol merging. |
internal/checker/checker.go | Replaced legacy modifier and assignment kind calls with their updated versions. |
internal/binder/nameresolver.go | Updated internal module/enum checks and exported GetLocalSymbolForExportDefault. |
internal/binder/binder.go | Switched to use GetJSDocAssignmentDeclarationKind in assignment binding logic. |
internal/astnav/tokens.go | Added GetTouchingToken as an alternative for token retrieval in AST. |
internal/ast/utilities.go | Introduced several new AST helper functions and renamed utility methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't read findallreferences.go yet but here are my comments for the rest. I focussed on changes needed for JS. I'll follow up with comments for the big file tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments on findallreferences.go, nothing substantive.
Seems like this fails to compile, probably due to more code getting added in other PRs. |
This port focuses on the logic needed to resolving symbols within a single file.
Todos after this PR:
lstestutil
capabilities.