Replace \xFE in symbol baselines with __ #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes output more like Strada, although not really any more correct. Most of these occurrences are likely mistakes.
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes symbol baselines by replacing the \xFE placeholder with __, making the output more consistent with Strada-like formatting.
- Added a
ReplaceAllcall aroundSymbolToStringto strip\xFE - Updated all test baseline files to use
__indexinstead of the legacy placeholder
Reviewed Changes
Copilot reviewed 135 out of 135 changed files in this pull request and generated no comments.
| File Pattern | Description |
|---|---|
| testdata/baselines/reference/submodule/compiler/**/*.symbols and *.symbols.diff | Replaced �index entries with __index in multiple baseline files |
| internal/testutil/tsbaseline/type_symbol_baseline.go | Wrapped fileChecker.SymbolToString(symbol) with ReplaceAll(..., "\xFE", "__") |
jakebailey
reviewed
Jun 3, 2025
Co-authored-by: Jake Bailey <[email protected]>
jakebailey
approved these changes
Jun 4, 2025
…script-go into no-more-thorn-in-baselines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes output more like Strada, although not really any more correct. Most of these occurrences are likely mistakes.