Ensure we don't copy OrderedMaps

[jakebailey]

Fixes #978

#978 broke because removeWildcardFilesWithLowerPriorityExtension passed the map by value and then attempted to delete from it. That will cause the internal map to be modified, but the key slice to not be modified in the caller. The fix is to pass by pointer.

To prevent this bug from happening in the future, use the noCopy pattern to make go vet check it. This reveals another place we weren't passing the map by pointer. That one's not a bug, but it could have been.

I don't have a real test for the problem as I think it's self explanatory and go vet will catch this, but I could figure out how to test it if required.

[Copilot]

Pull Request Overview

This PR addresses a bug where modifying an OrderedMap copy did not update its key slice in the caller, and introduces the noCopy pattern to prevent accidental copies. Key changes include:

• Changing the parameter of removeWildcardFilesWithLowerPriorityExtension to a pointer.
• Updating OrderedMap's MarshalJSON receiver from a value to a pointer.
• Adjusting hasCommonDeclaration to use pointer semantics for collections.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
internal/tsoptions/tsconfigparsing.go	Updated function signature and call to pass OrderedMap by pointer
internal/collections/ordered_map.go	Embedded noCopy and modified MarshalJSON receiver to prevent accidental copy
internal/checker/checker.go	Changed parameter type in hasCommonDeclaration to pointer for consistency

Comments suppressed due to low confidence (3)

internal/tsoptions/tsconfigparsing.go:1474

• Changing the parameter to a pointer fixes the bug where the map's key slice was not updated in the caller. Please verify that all callers now pass a pointer to ensure correct behavior.

func removeWildcardFilesWithLowerPriorityExtension(file string, wildcardFiles *collections.OrderedMap[string, string], extensions [][]string, keyMapper func(value string) string) {

internal/collections/ordered_map.go:206

• Switching to a pointer receiver for MarshalJSON avoids unintended copying of OrderedMap, ensuring that the noCopy pattern is effective. This change improves maintainability and safety.

func (m *OrderedMap[K, V]) MarshalJSON() ([]byte, error) {

internal/checker/checker.go:20197

• Updating the parameter to a pointer ensures that the collection is passed correctly without inadvertent copies. Confirm that related functions and callers are updated accordingly.

func (c *Checker) hasCommonDeclaration(symbols *collections.OrderedSet[*ast.Symbol]) bool {

[sheetalkamat]

May be we should do this for orderedSet and syncmap as well ?