Skip to content

Fix multi-endpoint Vision model menu and test connection#986

Merged
paullizer merged 4 commits into
microsoft:Developmentfrom
Xeelee33:update-vision-model-section
Jul 2, 2026
Merged

Fix multi-endpoint Vision model menu and test connection#986
paullizer merged 4 commits into
microsoft:Developmentfrom
Xeelee33:update-vision-model-section

Conversation

@chadpalmer

Copy link
Copy Markdown
Contributor

Summary

  • Fixes the Admin Settings Vision Model test button for multi-endpoint model deployments.
  • Preserves endpoint/model metadata on Vision Model dropdown options while keeping the saved value compatible with existing deployment-name settings.
  • Resolves the selected model endpoint server-side before running the Vision test, so models on non-legacy endpoints are tested against their configured endpoint.
  • Removes duplicate _test_multimodal_vision_connection backend logic.
  • Preserves GPT-5/o-series max_completion_tokens handling.
  • Adds functional regression coverage and fix documentation.

Validation

  • git diff --check upstream/Development
  • python -m py_compile application/single_app/config.py application/single_app/route_backend_settings.py functional_tests/test_multimodal_vision_multi_endpoint_connection.py
  • python functional_tests/test_multimodal_vision_multi_endpoint_connection.py
  • python scripts/check_swagger_routes.py application/single_app/route_backend_settings.py
  • python scripts/check_xss_sinks.py --base-sha upstream/Development --head-sha HEAD application/single_app/route_backend_settings.py application/single_app/static/js/admin/admin_settings.js application/single_app/templates/admin_settings.html
  • python scripts/check_broken_access_control.py --base-sha upstream/Development --head-sha HEAD application/single_app/route_backend_settings.py
  • python functional_tests/route_tests/test_route_blueprint_policy_inventory.py
  • python functional_tests/route_tests/test_route_unauthenticated_policy_contract.py
  • python functional_tests/route_tests/test_route_policy_test_coverage.py

Documentation

  • Updated docs/explanation/release_notes.md under v0.250.008.
  • Added docs/explanation/fixes/MULTI_ENDPOINT_VISION_TEST_CONNECTION_FIX.md.

Notes

  • Branch is up to date with upstream/Development.
  • Branch is pushed to origin/update-vision-model-section.
  • No secret-bearing files or local generated artifacts are included.
  • Browser UI tests were not run because no authenticated local browser app session was available during PR preparation.

@chadpalmer

Copy link
Copy Markdown
Contributor Author

@Bionic711 @paullizer Here's another update for the admin settings menu that allows Vision Model multi-endpoint model deployments. It also fixes the Test Vision Model button as well. I ran the PR prep prompt, and everything passed. Please let me know if you need anything else from me.

@paullizer

Copy link
Copy Markdown
Contributor

Security Review Notes
The new multi-endpoint vision test payload sends endpoint/model IDs and deployment metadata from the admin page, but the backend re-resolves the selected endpoint from saved server-side settings via resolve_model_endpoint_from_context(...) before building the client. I did not find browser-supplied endpoint URLs, keys, or arbitrary external hosts being trusted for the new multi-endpoint path.

No dependency manifests, lockfiles, Dockerfiles, GitHub Actions, deployer files, vendored assets, binaries, archives, minified files, or generated opaque artifacts changed. Dependency gate: not applicable.

No new external hosts, CDNs, webhooks, package registries, telemetry sinks, or model endpoints were introduced in added lines. The only network-relevant behavior remains the existing same-origin admin test call and the expected Azure/OpenAI client connection using configured settings.

Template-added data-* attributes use Jinja’s normal escaping, and JavaScript-created option labels use new Option(...), not raw HTML insertion. Existing nearby innerHTML usage was not newly introduced for this change.

@paullizer paullizer merged commit 8759f40 into microsoft:Development Jul 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants