-
Notifications
You must be signed in to change notification settings - Fork 682
Add file-based transfer APIs to build cache provider interface and all cache plugins #5746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
45
commits into
main
Choose a base branch
from
copilot/stream-cache-entry-for-http-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
66b650d
feat: add streaming support to build cache provider interface and HTT…
Copilot 64d05f1
fix lint warnings, add change files and API report update
Copilot d9972f5
address code review feedback: improve type annotations and JSDoc
Copilot 79b9197
Replace manual change files with rush change --bulk generated change …
Copilot bc7fa96
Use createReadStream/createWriteStream from FileSystem instead of fs …
Copilot 3dc688f
Use ensureFolderExists option in FileSystem.createWriteStream
Copilot 9a408ab
Add streaming support to Amazon S3 and Azure Storage build cache plugins
Copilot 2ad8219
Address code review: add documentation for type assertion and no-retr…
Copilot 80affd8
Gate streaming build cache behind useStreamingBuildCache experiment flag
Copilot 047586d
Update changelogs.
iclanton 689248c
Expand FileSystem.createWriteStream.
iclanton f685cc9
Use destructuring on rushConfiguration in PhasedScriptAction.
iclanton 97307f3
Clean up some duplicated types.
iclanton 5eb0cc3
Fix CI: add missing useStreamingBuildCache to bridge plugin, fix WebC…
Copilot d4c86b7
DRY up duplicated code across WebClient, AmazonS3Client, and HttpBuil…
Copilot 1254084
Address code review: use Buffer.isBuffer for clearer body length check
Copilot e001855
Change streaming cache APIs from Readable to NodeJS.ReadableStream
Copilot 81af1e1
DRY up Azure/HTTP cache providers, fix bridge plugin experiment config
Copilot 6654e21
Clean up FileSystemBuildCacheProvider.
iclanton 94d266d
fixup! Fix CI: add missing useStreamingBuildCache to bridge plugin, f…
iclanton 3ef0f43
Clean up WebClient.
iclanton 1e7942a
Handle Content-Encoding decompression in streaming WebClient path
Copilot 13562d9
Fix error message to show specific unsupported encoding value
Copilot ab6f07e
Fix CI: Move WebClient private members to module-level for rush-sdk t…
Copilot ba40685
Address review comments: fix response.resume race, stream retry bug, …
Copilot fd1cb75
Add unit tests for streaming cache APIs and fill buffer-based test gaps
Copilot bddd4ec
Fix buffer path error message to show specific unsupported encoding v…
iclanton 84304f8
Extract _getObjectName and _validateWriteAllowed helpers in S3 provider
iclanton 8aedb56
Extract _getContentEncodings helper to deduplicate encoding parsing
iclanton 15c0e11
Scope cacheEntryBuffer to its branch, use cloudCacheHit flag
iclanton 91c0e4d
Reuse a single WebClient instance in HttpBuildCacheProvider
iclanton 48aecb2
Use property shorthand in HttpBuildCacheProvider
iclanton d22938a
Fix unit test issues in streaming cache tests
iclanton b44bc44
Rework streaming cache APIs to file-based APIs with S3 payload signing
iclanton b474fda
Rename file-based cache APIs to tryDownload/tryUpload for clarity
iclanton e800785
Replace jest.mock('node:fs') with FileSystem spies in cache tests
iclanton caf3fec
Clean up partial file on failed cache download
iclanton e894980
Ensure parent directory exists before Azure downloadToFile
iclanton cebdcee
fixup! Ensure parent directory exists before Azure downloadToFile
iclanton 53f378e
Update change file descriptions, Azure JSDoc, and test names
iclanton d81d856
Fix S3 retry delay log unit from seconds to milliseconds
iclanton 3a322ed
fixup! Rework streaming cache APIs to file-based APIs with S3 payload…
iclanton 7c8e7c3
Add missing test coverage for file-based cache APIs
iclanton 5abf492
Fix "unknown bytes" debug log wording in HttpBuildCacheProvider
iclanton f8fecd4
Address dmichon-msft review comments
iclanton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
.../changes/@microsoft/rush/copilot-stream-cache-entry-for-http-plugin_2026-04-05-03-56.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "comment": "Add optional file-based transfer APIs (`tryDownloadCacheEntryToFileAsync`, `tryUploadCacheEntryFromFileAsync`) to `ICloudBuildCacheProvider`, allowing cache plugins to transfer cache entries directly to and from files on disk without buffering entire contents in memory. Implement in `@rushstack/rush-http-build-cache-plugin`, `@rushstack/rush-amazon-s3-build-cache-plugin`, and `@rushstack/rush-azure-storage-build-cache-plugin`. Gated behind the `useDirectFileTransfersForBuildCache` experiment.", | ||
| "type": "none", | ||
| "packageName": "@microsoft/rush" | ||
| } | ||
| ], | ||
| "packageName": "@microsoft/rush", | ||
| "email": "198982749+Copilot@users.noreply.github.com" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be mentioned in the changelog?