feat(fabric): Implement keyboard events and drag/drop APIs for TextInput #2719
+223
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff adds keyboard event handling to the TextInput component by testing the valid keys for manual keyboard event handling and dispatching key events to the View component keyboard handling method. Test Plan: - Run Workplace Chat with Fabric enabled. - Open a message thread with 3 or more participants. - Type `@` to display the reference selector. - Change the selection with the up and down arrows and select an entry with tab to test the custom keyboard event handling. https://pxl.cl/4ghtH Reviewers: shawndempsey, #rn-desktop Reviewed By: shawndempsey Differential Revision: https://phabricator.intern.facebook.com/D53241729 Tasks: T157889406, T154618477
Summary: Add support for drag and drop to the TextInput component. This re-uses the drag and drop handlers implemented on the View component to support dropping images/files on TextInput views directly. Test Plan: * Run Zeratul with Fabric enabled * Drag and drop an image on the message composer * Send the attachment https://pxl.cl/4ldBX Reviewers: shawndempsey, #rn-desktop Reviewed By: shawndempsey Differential Revision: https://phabricator.intern.facebook.com/D53674740
Saadnajmi
changed the title
tido64
approved these changes
Oct 8, 2025
packages/rn-tester/js/examples/KeyboardEventsExample/KeyboardEventsExample.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cherry pick changes from #2117 to enable onKeyDown/onKeyUp/keyDownEvents/keyUpEvents and onDragEnter/onDragLeave/onDrop on TextInput. Note that onPaste (which also uses dataTransfer) is omitted.
Test Plan:
Updated the example test page to showcase the keyboard APIs with TextInput.