fix: Add proper constraints for macOS dev loading view #2707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g view - Add contentView initialization and container constraints for macOS - Fix layout issues with the dev loading view on macOS platform - Ensure proper positioning and sizing of the loading message window Fixes microsoft#2706
|
@microsoft-github-policy-service agree [company="{didi}"] |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@microsoft-github-policy-service agree |
|
This is the effect after the repair. |
|
Saadnajmi
reviewed
Sep 30, 2025
- Replace contentViewController.view with contentView for proper view hierarchy - Unify constraint logic across iOS and macOS platforms - Use shared constraint array for better code organization - Fix container constraints to properly fill parent view on macOS - Maintain platform-specific label positioning (bottom on iOS, center on macOS) Fixes issue microsoft#2706
Saadnajmi
reviewed
Oct 8, 2025
Saadnajmi
requested changes
Oct 8, 2025
- Fix macOS contentView usage by using contentViewController.view instead of contentView - Simplify constraint setup by separating iOS and macOS specific logic - Remove shared constraint array approach for better code clarity - Ensure proper initialization of contentView for macOS platform This addresses the layout issues in issue microsoft#2706 with a cleaner implementation.
- Remove duplicate contentView initialization in macOS code path - Fix file ending newline formatting - Simplify the constraint setup by removing unnecessary contentView creation - The contentView is already properly initialized by the NSWindow This further refines the fix for issue microsoft#2706 with cleaner code.
Saadnajmi
approved these changes
Oct 11, 2025
Saadnajmi
changed the title
|
@Saadnajmi Thanks for the approval. GitHub still shows “Merging is blocked: A conversation must be resolved before this pull request can be merged.” |
I plan to merge and backport to 0.79 on Monday, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2706
Summary:
Test Plan: