Skip to content

feat: Use peerDependencies to get Hermes version on stable branches #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025
Merged

feat: Use peerDependencies to get Hermes version on stable branches #2531

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50f1238
Use peerDependencies to get Hermes version on stable branches
Jun 30, 2025
5c49cdb
Respond to PR feedback
Jul 1, 2025
88ab262
Adjust error handling slightly
Jul 1, 2025
4d6bbdb
Ensure version is non-nil before entering Pod::Spec.new
Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/react-native/sdks/hermes-engine/hermes-engine.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ end
# package.json
package = JSON.parse(File.read(File.join(react_native_path, "package.json")))
# [macOS
rn_version = package['version']
version = findLatestVersionWithArtifact(rn_version) || rn_version
version = findLatestVersionWithArtifact(package) || package['version']
# macOS]

source_type = hermes_source_type(version, react_native_path)
Expand Down
12 changes: 4 additions & 8 deletions packages/react-native/sdks/hermes-engine/hermes-utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,18 +298,14 @@ def resolve_url_redirects(url)

# [macOS react-native-macos does not publish macos specific hermes artifacts
# so we attempt to find the latest patch version of the iOS artifacts and use that
def findLatestVersionWithArtifact(version)
if version == "1000.0.0"
def findLatestVersionWithArtifact(package)
if package['version'] == "1000.0.0"
# The main branch builds from source, so skip the artifact check
return nil
end

# See https://central.sonatype.org/search/rest-api-guide/ for details on query params
versionWithoutPatch = "#{version.match(/^(\d+\.\d+)/)}"
res, = Open3.capture3("curl -s https://search.maven.org/solrsearch/select?q=g:com.facebook.react+AND+a:react-native-artifacts+AND+v:#{versionWithoutPatch}.*&core=gav&rows=1&wt=json")
wt = JSON.parse(res)
response = wt['response']
return response['docs'][0]['v'] unless response['numFound'] == 0
# This assumes that whatever peer dependency we specify has an artifact
return package['peerDependencies']['react-native']
end
# macOS]

Expand Down
Loading