-
Notifications
You must be signed in to change notification settings - Fork 149
fix: expose react-native-macos cli commands #2529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t paths Co-authored-by: Saadnajmi <[email protected]>
yarn start no longer launches metro…patibility Co-authored-by: Saadnajmi <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: Saadnajmi <[email protected]>
Co-authored-by: Saadnajmi <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot can you revert the changes to |
Co-authored-by: Saadnajmi <[email protected]>
I've reverted the package.json changes and implemented a solution that doesn't use hardcoded node_modules paths. The fix now uses |
|
@copilot can we keep yarn start as an alias of react-native-macos start? |
Co-authored-by: Saadnajmi <[email protected]>
I've updated the solution to keep Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: Saadnajmi <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The
yarn startcommand inpackages/rn-testerwas failing because the binary name in thereact-nativepackage didn't match the package namereact-native-macos.Problem
yarn startinpackages/rn-testerresulted in "command not found: react-native-macos"npx react-native-macos startas a workaroundbinfield inpackages/react-native/package.jsondefined the binary as"react-native"instead of"react-native-macos"Solution
binfield inpackages/react-native/package.jsonfrom"react-native": "cli.js"to"react-native-macos": "cli.js"to match the package namestartandandroidscripts inpackages/rn-tester/package.jsonto use the correct relative path to the binary:../../node_modules/.bin/react-native-macosTesting
yarn startnow works frompackages/rn-testerdirectoryyarn startworks from root directory (delegates to rn-tester)npx react-native-macos startcontinues to work as beforescripts/objc-test.shcontinue to work (they useyarn startfrom rn-tester context)Both the standard React Native workflow (
yarn start) and the existing workaround (npx react-native-macos start) now function correctly.Fixes #2528.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/react-native-community/rn-diff-purge/tagsnode /home/REDACTED/work/react-native-macos/react-native-macos/node_modules/.bin/react-native start(http block)node ../../node_modules/.bin/react-native-macos start(http block)/usr/local/bin/node ../../node_modules/.bin/react-native-macos start(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.