Skip to content

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Nov 1, 2024

Summary:

It doesn't look like we're using hermes-inspector-msggen and react-native-bots anywhere, so I think it makes sense to not include them when installing packages. This should also reduce the number of dependencies we need to download/install.

Test Plan:

n/a

@tido64 tido64 requested a review from a team as a code owner November 1, 2024 12:40
Copy link
Collaborator

@Saadnajmi Saadnajmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansenyy any chance this changes any of the CG alerts?

@hansenyy
Copy link

hansenyy commented Nov 6, 2024

Not the ones that's already there since they aren't related to the two packages Tommy's removing. But this should reduce the number of alerts in the future.

@Saadnajmi Saadnajmi merged commit d61d747 into main Nov 7, 2024
14 checks passed
@tido64 tido64 deleted the tido/exclude-unused-packages branch November 7, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants