fix: Properly clean up RCTDevLoadingView on hide #2201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2024
tido64
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #2183
This PR fixes two issues with RCTDevLoadingView:
In the macOS implementation of
RCTDevLoadingView, we forgot to do some cleanup of instance variables onhide, which was causing the loading view to stick around.The NSWindow that RCTDevLoadingView used would return false for
canBecomeKeyWindow. Somewhere internal to Appkit,makeKeyWindowwas called, would fail, and produce a warning in the Xcode console. By making the window an NSPanel instead, we can avoid this issue.Test Plan:
Loaded RNTester a couple of times and didn't observe an issue with the loading view sticking around.