Update API ReadOpAttr and CreateOpAttr for string type to unblock EPs to process EPContext node for ep_cache_context with bytes stream #25389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… '\0' at the end.
Member
yuslepukhin
reviewed
Jul 16, 2025
yuslepukhin
reviewed
Jul 16, 2025
Update example code
Contributor
Author
will remove it. In reply to: 3080645591 Refers to: include/onnxruntime/core/providers/utils/ort_graph_to_proto.h:668 in 3863990. [](commit_id = 3863990, deletion_comment = False) |
Member
|
HectorSVC
changed the title
jywu-msft
approved these changes
Jul 18, 2025
Contributor
|
Hi there! We haven't cut the release branch for this version yet, so I'm removing the |
qti-yuduo
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Aug 8, 2025
… to process EPContext node for ep_cache_context with bytes stream (microsoft#25389) The existing API ReadOpAttr & CreateOpAttr for string type always assume there '\0' at the end. It blocks the EPs to embed/read the context binary byte buffer into EPContext node ep_cache_context attribute. Update the customer op API ReadOpAttr for string type to avoid adding '\0' at the end. Update CreateOpAttr API to construct the string with len. Keep the strings type processing as it is for now.
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
… to process EPContext node for ep_cache_context with bytes stream (microsoft#25389) The existing API ReadOpAttr & CreateOpAttr for string type always assume there '\0' at the end. It blocks the EPs to embed/read the context binary byte buffer into EPContext node ep_cache_context attribute. Update the customer op API ReadOpAttr for string type to avoid adding '\0' at the end. Update CreateOpAttr API to construct the string with len. Keep the strings type processing as it is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing API ReadOpAttr & CreateOpAttr for string type always assume there '\0' at the end. It blocks the EPs to embed/read the context binary byte buffer into EPContext node ep_cache_context attribute.
Update the customer op API ReadOpAttr for string type to avoid adding '\0' at the end.
Update CreateOpAttr API to construct the string with len.
Keep the strings type processing as it is for now.