Skip to content

Download protobuf dependency on ARM64 build host #24847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qc-tbhardwa
Copy link

Windows on ARM support AMD64 emulation, so we can use win64 version of protoc.

Description
Compilation on ARM64 machine fails due to missing protoc dependency.

Motivation and Context
With this change we can compile onnxruntime on Windows on Arm devices without setting protobuf manually. CMake will download and setup protoc dependency.

Windows on ARM support AMD64 emulation. So we can use win64 version of
protoc.
@HectorSVC
Copy link
Contributor

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@HectorSVC
Copy link
Contributor

We have built on ARM64 machine for a long time, never encounter any issue with protoc. Don't know what's the issue you you encountered.

@qc-tbhardwa
Copy link
Author

If we try to compile arm64ec on arm64 device then it fails with below error.

Doing crosscompiling
Numpy version: 2.2.5
-- Loading Dependencies URLs ...
-- Loading Dependencies ...
-- Abseil source dir:C:/repos/onnxruntime_gqa/build/arm64_build_err_ec/Release/_deps/abseil_cpp-src
-- CMAKE_HOST_SYSTEM_NAME: Windows
CMake Error at external/onnxruntime_external_deps.cmake:162 (message):
ONNX_CUSTOM_PROTOC_EXECUTABLE must be set to cross-compile.
Call Stack (most recent call first):
CMakeLists.txt:699 (include)

For cross-compiling, we are not fetching protoc if processor is AM64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants