WIP #24837
Closed
WIP #24837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
In what situation will row_sum_shared be 0? As long as there is >=1 element(s), exp(value-max_value) = exp(0) = 1 when value = max_value, so row_sum_shared shall >= 1. |
Contributor
Author
|
Continued in #24855 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+53
to
+55
| TEST(SoftmaxOperator, webgpu_nan) { | ||
| OpTester test("Softmax", 13); // axis default is -1 | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| TEST(SoftmaxOperator, webgpu_nan) { | |
| OpTester test("Softmax", 13); // axis default is -1 | |
| TEST(SoftmaxOperator, webgpu_nan) { | |
| OpTester test("Softmax", 13); // axis default is -1 | |
Comment on lines
+61
to
+63
| test.AddOutput<float>("Y", dimensions, expected_result); | ||
|
|
||
| // explicitly disable CPU EP for this test since CPU implementation does not handle NaN |
Contributor
There was a problem hiding this comment.
Suggested change
| test.AddOutput<float>("Y", dimensions, expected_result); | |
| // explicitly disable CPU EP for this test since CPU implementation does not handle NaN | |
| test.AddOutput<float>("Y", dimensions, expected_result); | |
| // explicitly disable CPU EP for this test since CPU implementation does not handle NaN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.