UefiCpuPkg/PeiMpLib: Only allocate ACPI NVS AP loop code buffer on S3 resume #1523
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resume This commit allocated an ACPI NVS buffer in PEI: tianocore/edk2@cdc1a88 This is a RT visible memory type that remains fragmented against the overall `EfiACPIMemoryNVS` memory bucket allocated by the DXE Core. Signed-off-by: Michael Kubacki <[email protected]>
os-d
approved these changes
Oct 8, 2025
apop5
approved these changes
Oct 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1523 +/- ##
================================================
Coverage ? 4.85%
================================================
Files ? 140
Lines ? 26776
Branches ? 527
================================================
Hits ? 1301
Misses ? 25451
Partials ? 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kuqin12
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit allocated an ACPI NVS buffer in PEI:
tianocore/edk2@cdc1a88
This is a RT visible memory type that remains fragmented against the overall
EfiACPIMemoryNVSmemory bucket allocated by the DXE Core.How This Was Tested
Integration Instructions
EfiACPIMemoryNVSwill not be allocated in PEI outside of S3 resume (as indicated with boot mode). This is not expected to be breaking or impact other flows.