Add case to verify provision with swiotlb=force #4041
+234
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityagesh
force-pushed
the
aditya/swiotlb=force
branch
from
a63d148 to
3c24174
Compare
squirrelsc
reviewed
Oct 13, 2025
| def __init__(self, node: "Node", *args: Any, **kwargs: Any) -> None: | ||
| super().__init__("update-grub", "grub-common", node, *args, **kwargs) | ||
|
|
||
| def set_kernel_cmdline_arg(self, arg: str, value: str) -> None: |
There was a problem hiding this comment.
Share as much code as you can with Azl3 by using a private function in this file to handle the common logic.
adityagesh
force-pushed
the
aditya/swiotlb=force
branch
from
27edc93 to
010e310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiotlb=force is required for CVMs, which will support AN.
This is for a MANA driver regression caused by
730ff06d3f5c ("net: mana: Use page pool fragments for RX buffers instead of full pages to improve memory efficiency.").
The VM fails to get an IP via DHCP -- this is 100% repro.
This is not a required param for non-cvm, but it should work well with non-cvm also.