kdump: Replace CvmDisabled with before_case SecurityProfile check #4032
+21
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Oct 6, 2025
squirrelsc
reviewed
Oct 6, 2025
vyadavmsft
force-pushed
the
vyadav_hyperv_sf
branch
from
5eea5a9 to
ebbf6ea
Compare
vyadavmsft
changed the title
squirrelsc
reviewed
Oct 10, 2025
| if isinstance(node.os, BSD) or isinstance(node.os, Windows): | ||
| raise SkippedException(f"{node.os} is not supported.") | ||
| # Skip kdump tests on CVMs (Confidential VMs) as they are not supported | ||
| if node.features.is_supported(SecurityProfile): |
There was a problem hiding this comment.
should it be if not node.features.is_supported(SecurityProfile):?
There was a problem hiding this comment.
node.features.is_supported(SecurityProfile) returns True only when the VM has SecurityProfile features (i.e., it's a CVM/SecureBoot VM), and returns False for regular Standard VMs where SecurityProfile is not present/applicable.
There was a problem hiding this comment.
See the if block, the test case should be skipped, if SecurityProfile is not support, instead of SecurityProfile supported, and then skip.
squirrelsc
reviewed
Oct 10, 2025
| # Skip kdump tests on CVMs (Confidential VMs) as they are not supported | ||
| if node.features.is_supported(SecurityProfile): | ||
| raise SkippedException( | ||
| "Kdump is not supported on Confidential VMs (CVMs). " |
There was a problem hiding this comment.
Mention about the platform doesn't support security profile.
|
@kamalca , please help check if the latest change still support your scenarios. |
vyadavmsft
force-pushed
the
vyadav_hyperv_sf
branch
from
f9c6ae9 to
6f95c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.