avoid fetching information unnecessarily when rerun env #3515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Nov 15, 2024
| self._environment_information = self.environment.get_information() | ||
| # avoid fetching information unnecessarily when rerun env | ||
| force_run = True | ||
| if ( |
There was a problem hiding this comment.
The if block needs more explanation to understand what's the problem is fixed. so it won't be confused in future.
|
@LiliDeng Why is it not possible to fix I am fine with relying on cache to save time, but we should not rely on cache for correctness. We should aim for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.