grouped packages propagate the change type based on ChangeType order #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not change file load order
|
|
|
Hey team - it's been a while. Do we think any movement can happen on this MR or should we stop waiting? Are there people we can reach out to? Again, this lib is great and we love it. We'd appreciate some expectation-setting if possible :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, they were ordered based on the filesystem's sort order. The change type of the last change file in the array of changes for a group would be propagated to all the change files in that group.
This PR figures out the max change type for the entire group and sets that into the
calculatedChangeTypesfor the packages in the group.