Makes changes to the “CI Integration” page #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenotron
reviewed
May 16, 2022
docs/concepts/ci-integration.md
Outdated
| **2.1 Configure Git.** You can set up your Azure DevOps pipeline to add git credentials with Git CLI or you can extrapolate it in a Node script like this: | ||
| ```js | ||
| const shell = require('shelljs'); |
There was a problem hiding this comment.
Why don't we give example in terms of the yaml pipeline itself? shelling out to a task in just-scripts seems overkill?
I'm thinking something like this:
steps:
- script: git config .... There was a problem hiding this comment.
You have most of it down below in the yaml example
There was a problem hiding this comment.
👌👌 Good point! I was kind of on a fence on this one. Ideally, I would want ADO to have a pre-built task for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes changes to the “CI Integration” page
-yflag to the CI script example