Always use p-graph for publish and hook orchestration #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
force-pushed
the
ecraig/graph
branch
from
9221b7b to
e692a66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#998 added support for concurrent publishing and hook calls but kept the previous logic for when concurrency=1 (default). This PR updates it to use p-graph's orchestration and toposorting logic in all cases.
Since
p-graphthrows an array of errors on failure (which almost certainly won't log well), add more granular try/catch and specific error array handling inpublishRegistryandcallHook.Also update workspace-tools to remove a deep import.