Skip to content

Added openapi metadata for simswap and kyc match #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

vickybesra
Copy link
Contributor

Description

  • Added OpenAPI metadata for SimSwap and KYC-Match for their respective latest versions.
  • Verified the existing phone numbers to determine if they are real or not.
  • I added an example of fake phone numbers for testing purposes.

Related issue(s)

See also #41

@vickybesra
Copy link
Contributor Author

@yada PTAL

Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

'POST /retrieve-date':
"+937018305578":
request:
toto: tata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error I guess ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the metadata by removing the "toto: tata"
@yada PTAL

@vickybesra vickybesra force-pushed the add-openapi-metadata branch 2 times, most recently from 6072808 to 32830a9 Compare May 12, 2025 17:29
@vickybesra
Copy link
Contributor Author

I have also added new APIs for CAMERA and their respective metadata examples

@vickybesra vickybesra requested a review from yada May 12, 2025 17:35
@vickybesra vickybesra force-pushed the add-openapi-metadata branch from 32830a9 to b5b8f87 Compare May 17, 2025 16:23
@vickybesra vickybesra force-pushed the add-openapi-metadata branch from b5b8f87 to ea97ffa Compare May 17, 2025 16:50
@vickybesra
Copy link
Contributor Author

@yada PTAL

@yada yada added the documentation Improvements or additions to documentation label May 18, 2025
Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with thanks, let's test and iterate on it now

@yada yada merged commit 17f2b84 into microcks:main May 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants