Skip to content

Fix escape crowdin jipt url #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fix escape crowdin jipt url #1222

merged 1 commit into from
Jun 20, 2025

Conversation

microbit-grace
Copy link
Contributor

@microbit-grace microbit-grace commented Jun 20, 2025

Redirect to a valid URL when deciding not to log into crowdin.

Issue:

  1. Visit https://python.microbit.org/v/3?flag=translate
  2. Click on the close button instead of logging into Crowdin.
  3. Get redirected to https://python.microbit.org/v/%VITE_FULL_URL, which is a request error

Copy link

github-actions bot commented Jun 20, 2025

@microbit-grace microbit-grace requested a review from a team June 20, 2025 08:59
Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microbit-grace microbit-grace merged commit 0e9d49e into main Jun 20, 2025
2 checks passed
@microbit-grace microbit-grace deleted the fix-esc-jipt branch June 20, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants