Skip to content

Conversation

@ThomasCAI-mlv
Copy link
Collaborator

@ThomasCAI-mlv ThomasCAI-mlv commented Dec 5, 2024

Add the possibility to find the namespace which is the owner of a topic, thanks to a given topic name.

The PR adds the topic query parameter in the LIST namespace API:

  • if the query parameter is an empty string, the endpoint doesn't filter at all by the topic name.
  • if the query parameter is not empty, the endpoint finds the namespace which is the owner of the topic. It returns no namespace if no namespace is owner of the topic (or the topic doesn't exist).

Maybe, the implementation could be 2 additional parameters, resource type and resource name, to allow the search on all types of resources (not only topics), I left it to discussion.

@ThomasCAI-mlv ThomasCAI-mlv added the feature This issue or pull request contains a new feature label Dec 5, 2024
@ThomasCAI-mlv ThomasCAI-mlv self-assigned this Dec 5, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link
Collaborator

@loicgreffier loicgreffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasCAI-mlv OK for me

@loicgreffier loicgreffier merged commit c51d9f3 into master Dec 6, 2024
4 checks passed
@loicgreffier loicgreffier deleted the feat/find-namespace-from-topic branch December 6, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature This issue or pull request contains a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants