Skip to content

Fix connect worker getting rebalanced in integration tests #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix connect worker getting rebalanced in integration tests #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9e43eb
Fix connect worker rebalance in integration tests
loicgreffier Oct 14, 2024
d257ab5
Set sleep to 3000
loicgreffier Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/test/java/com/michelin/ns4kafka/integration/ConnectClusterIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,8 @@
import com.michelin.ns4kafka.model.RoleBinding.Verb;
import com.michelin.ns4kafka.model.connect.cluster.ConnectCluster;
import com.michelin.ns4kafka.model.connect.cluster.VaultResponse;
import com.michelin.ns4kafka.service.executor.ConnectorAsyncExecutor;
import com.michelin.ns4kafka.service.executor.TopicAsyncExecutor;
import com.michelin.ns4kafka.validation.ConnectValidator;
import com.michelin.ns4kafka.validation.TopicValidator;
import io.micronaut.context.ApplicationContext;
import io.micronaut.core.type.Argument;
import io.micronaut.http.HttpMethod;
import io.micronaut.http.HttpRequest;
Expand All @@ -43,19 +40,10 @@
@Slf4j
@MicronautTest
class ConnectClusterIntegrationTest extends KafkaConnectIntegrationTest {
@Inject
private ApplicationContext applicationContext;

@Inject
@Client("/")
private HttpClient ns4KafkaClient;

@Inject
private List<TopicAsyncExecutor> topicAsyncExecutorList;

@Inject
private List<ConnectorAsyncExecutor> connectorAsyncExecutorList;

private String token;

@BeforeAll
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/michelin/ns4kafka/integration/ConnectorIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ private void forceConnectorSynchronization() throws InterruptedException {
.blockLast();

// Wait for Kafka Connect to deploy and update connectors
Thread.sleep(4000);
Thread.sleep(3000);
}

private void waitForConnectorAndTasksToBeInState(String connector, Connector.TaskState state)
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/com/michelin/ns4kafka/integration/container/KafkaConnectIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import io.micronaut.core.annotation.NonNull;
import java.util.HashMap;
import java.util.Map;
import java.util.UUID;
import org.junit.jupiter.api.TestInstance;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.containers.wait.strategy.Wait;
Expand All @@ -20,7 +21,7 @@ public abstract class KafkaConnectIntegrationTest extends KafkaIntegrationTest {
.withExposedPorts(8083)
.withEnv("CONNECT_BOOTSTRAP_SERVERS", "broker:9092")
.withEnv("CONNECT_REST_ADVERTISED_HOST_NAME", "connect")
.withEnv("CONNECT_GROUP_ID", "compose-connect-group")
.withEnv("CONNECT_GROUP_ID", "compose-connect-group-" + UUID.randomUUID())
.withEnv("CONNECT_CONFIG_STORAGE_TOPIC", "docker-connect-configs")
.withEnv("CONNECT_CONFIG_STORAGE_REPLICATION_FACTOR", "1")
.withEnv("CONNECT_OFFSET_STORAGE_TOPIC", "docker-connect-offsets")
Expand Down