-
Notifications
You must be signed in to change notification settings - Fork 147
fix: newlines for messages in log tail #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A small but impactful quality of life fix for your consideration @kiukchung, @tonykao8080 @d4l3k @andywag |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
+ Coverage 91.72% 91.76% +0.04%
==========================================
Files 86 86
Lines 6668 6668
==========================================
+ Hits 6116 6119 +3
+ Misses 552 549 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2dcd7e7 to
7b1295b
Compare
7b1295b to
d6115d9
Compare
|
Please check the new version @kiukchung |
d6115d9 to
3d34b7f
Compare
|
@kiukchung has imported this pull request. If you are a Meta employee, you can view this in D89891707. |
|
Thanks for checking @kiukchung, should I squash and merge now? (and for the future PRs) |
done! |
logshows lines separated by newlines correctly, butlog -thas all lines jumbled up.Test plan:
[x] added unit test