Skip to content

Conversation

@clumsy
Copy link
Collaborator

@clumsy clumsy commented Dec 19, 2025

log shows lines separated by newlines correctly, but log -t has all lines jumbled up.

Test plan:
[x] added unit test

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2025
@clumsy
Copy link
Collaborator Author

clumsy commented Dec 19, 2025

A small but impactful quality of life fix for your consideration @kiukchung, @tonykao8080 @d4l3k @andywag

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.76%. Comparing base (c9b3dde) to head (a82cdf8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
+ Coverage   91.72%   91.76%   +0.04%     
==========================================
  Files          86       86              
  Lines        6668     6668              
==========================================
+ Hits         6116     6119       +3     
+ Misses        552      549       -3     
Flag Coverage Δ
unittests 91.76% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clumsy clumsy force-pushed the fix/log_tail_newline branch from 2dcd7e7 to 7b1295b Compare December 19, 2025 18:03
@clumsy clumsy force-pushed the fix/log_tail_newline branch from 7b1295b to d6115d9 Compare December 23, 2025 21:26
@clumsy
Copy link
Collaborator Author

clumsy commented Dec 23, 2025

Please check the new version @kiukchung

@clumsy clumsy force-pushed the fix/log_tail_newline branch from d6115d9 to 3d34b7f Compare December 23, 2025 21:39
@meta-codesync
Copy link

meta-codesync bot commented Dec 29, 2025

@kiukchung has imported this pull request. If you are a Meta employee, you can view this in D89891707.

@clumsy
Copy link
Collaborator Author

clumsy commented Dec 29, 2025

Thanks for checking @kiukchung, should I squash and merge now? (and for the future PRs)

@kiukchung kiukchung merged commit 772fe39 into meta-pytorch:main Dec 29, 2025
22 checks passed
@kiukchung
Copy link
Contributor

Please check the new version @kiukchung

done!

@clumsy clumsy deleted the fix/log_tail_newline branch December 29, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants