Feature to add cluster-auth as an option (i.e. k8s service account support). #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@johnwhumphreys has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88568003. |
johnwhumphreys
added a commit
to johnwhumphreys/torchx
that referenced
this pull request
Dec 8, 2025
…pport). (meta-pytorch#1172) Summary: This diff adds cluster-auth as an option in the k8s scheduler by first checking if it works, and then falling back to the old auth scheme. So, if we are in pod in a k8s cluster and the pod has a k8s service-account, it will use that. If it does not, it will try to fallback to a kubeconfig. Differential Revision: D88568003
johnwhumphreys
force-pushed
the
export-D88568003
branch
from
7c9336d to
7e61ec1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1172 +/- ##
=======================================
Coverage 91.71% 91.72%
=======================================
Files 86 86
Lines 6665 6668 +3
=======================================
+ Hits 6113 6116 +3
Misses 552 552
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johnwhumphreys
added a commit
to johnwhumphreys/torchx
that referenced
this pull request
Dec 8, 2025
…pport). (meta-pytorch#1172) Summary: This diff adds cluster-auth as an option in the k8s scheduler by first checking if it works, and then falling back to the old auth scheme. So, if we are in pod in a k8s cluster and the pod has a k8s service-account, it will use that. If it does not, it will try to fallback to a kubeconfig. Differential Revision: D88568003
johnwhumphreys
force-pushed
the
export-D88568003
branch
from
7e61ec1 to
bb16fae
Compare
AbishekS
approved these changes
Dec 8, 2025
johnwhumphreys
added a commit
to johnwhumphreys/torchx
that referenced
this pull request
Dec 8, 2025
…pport). (meta-pytorch#1172) Summary: This diff adds cluster-auth as an option in the k8s scheduler by first checking if it works, and then falling back to the old auth scheme. So, if we are in pod in a k8s cluster and the pod has a k8s service-account, it will use that. If it does not, it will try to fallback to a kubeconfig. Reviewed By: AbishekS Differential Revision: D88568003
johnwhumphreys
force-pushed
the
export-D88568003
branch
from
bb16fae to
6cff436
Compare
johnwhumphreys
added a commit
to johnwhumphreys/torchx
that referenced
this pull request
Dec 8, 2025
…pport). (meta-pytorch#1172) Summary: This diff adds cluster-auth as an option in the k8s scheduler by first checking if it works, and then falling back to the old auth scheme. So, if we are in pod in a k8s cluster and the pod has a k8s service-account, it will use that. If it does not, it will try to fallback to a kubeconfig. Reviewed By: AbishekS Differential Revision: D88568003
johnwhumphreys
force-pushed
the
export-D88568003
branch
from
6cff436 to
4a3b188
Compare
johnwhumphreys
added a commit
to johnwhumphreys/torchx
that referenced
this pull request
Dec 9, 2025
…pport). (meta-pytorch#1172) Summary: This diff adds cluster-auth as an option in the k8s scheduler by first checking if it works, and then falling back to the old auth scheme. So, if we are in pod in a k8s cluster and the pod has a k8s service-account, it will use that. If it does not, it will try to fallback to a kubeconfig. Reviewed By: AbishekS Differential Revision: D88568003
johnwhumphreys
force-pushed
the
export-D88568003
branch
from
4a3b188 to
64cc770
Compare
johnwhumphreys
added a commit
to johnwhumphreys/torchx
that referenced
this pull request
Dec 9, 2025
…pport). (meta-pytorch#1172) Summary: This diff adds cluster-auth as an option in the k8s scheduler by first checking if it works, and then falling back to the old auth scheme. So, if we are in pod in a k8s cluster and the pod has a k8s service-account, it will use that. If it does not, it will try to fallback to a kubeconfig. Reviewed By: AbishekS Differential Revision: D88568003
johnwhumphreys
force-pushed
the
export-D88568003
branch
from
64cc770 to
15f4a22
Compare
…pport). (meta-pytorch#1172) Summary: This diff adds cluster-auth as an option in the k8s scheduler by first checking if it works, and then falling back to the old auth scheme. So, if we are in pod in a k8s cluster and the pod has a k8s service-account, it will use that. If it does not, it will try to fallback to a kubeconfig. Reviewed By: AbishekS Differential Revision: D88568003
johnwhumphreys
force-pushed
the
export-D88568003
branch
from
15f4a22 to
45502c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff adds cluster-auth as an option in the k8s scheduler by first checking if it works, and then falling back to the old auth scheme. So, if we are in pod in a k8s cluster and the pod has a k8s service-account, it will use that. If it does not, it will try to fallback to a kubeconfig.
Differential Revision: D88568003