Expose cpu_fallback in VideoDecoder API #1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
added 2 commits
December 3, 2025 12:53
mollyxu
commented
Dec 4, 2025
mollyxu
changed the title
mollyxu
changed the title
NicolasHug
reviewed
Dec 4, 2025
Contributor
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks for working on this @mollyxu ! Left a few comments and suggestions regarding the implementation, let me know if I can clarify anything.
NicolasHug
reviewed
Dec 5, 2025
NicolasHug
reviewed
Dec 8, 2025
Dan-Flores
reviewed
Dec 8, 2025
Dan-Flores
reviewed
Dec 8, 2025
Dan-Flores
approved these changes
Dec 8, 2025
Contributor
Dan-Flores
left a comment
Dan-Flores
left a comment
There was a problem hiding this comment.
Left some small comments, but after those LGTM!
NicolasHug
approved these changes
Dec 9, 2025
Contributor
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks a lot for working on this @mollyxu ! Left 2 last minor comments below but LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose cpu_fallback in VideoDecoder API
Expose the
cpu_fallbackproperty in the public API to allow users to check whether the video decoder fell back to CPU decoding. #943The
FallbackInfoclass provides a clean interface for users to check decoder fallback status:bool(fallback_info)returns True if any fallback occurredstr(fallback_info)provides a human-readable explanation of why fallback happenedThe
cpu_fallbackproperty onVideoDecoderreturns aFallbackInfoinstance that can be queried after decoding at least one frame. This helps users understand why GPU decoding may not be used and debug performance issues.