Skip to content

Conversation

@stephanlachnit
Copy link
Contributor

Will fail to build on Windows due to #2436 (comment) (this problem already persists with current cpr). I pledge to merge this anyway since this doesn't change the status quo. Alternatively, I could disable Windows builds in CI and error in the Meson build files if this is preferred.

@stephanlachnit
Copy link
Contributor Author

Opened an issue about symbol visibility here: libcpr/cpr#1273

Copy link
Collaborator

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to let Windows CI continue to fail, I think.

@stephanlachnit
Copy link
Contributor Author

Updated to 1.14.1

@stephanlachnit stephanlachnit changed the title cpr: update to 1.13.0 cpr: update to 1.14.1 Dec 22, 2025
@neheb
Copy link
Collaborator

neheb commented Dec 23, 2025

2025-12-22T15:18:08.3728429Z DEPRECATION: Variable substitution with boolean value 'CURL_CA_BUNDLE' is deprecated.
2025-12-22T15:18:08.3728437Z 
2025-12-22T15:18:08.3728636Z subprojects\curl-8.12.1\meson.build:1751:21: ERROR: Fatal warnings enabled, aborting
2025-12-22T15:18:08.3728689Z 

Interesting.

@stephanlachnit
Copy link
Contributor Author

2025-12-22T15:18:08.3728429Z DEPRECATION: Variable substitution with boolean value 'CURL_CA_BUNDLE' is deprecated.
2025-12-22T15:18:08.3728437Z 
2025-12-22T15:18:08.3728636Z subprojects\curl-8.12.1\meson.build:1751:21: ERROR: Fatal warnings enabled, aborting
2025-12-22T15:18:08.3728689Z 

Interesting.

@neheb this seems unrelated to the cpr wrap, can we merge this anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants