abseil-cpp: enable tests, add tracing.cc to base sources #2432
+850
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache-hb
force-pushed
the
abseil-cpp
branch
9 times, most recently
from
e405feb to
dca64b2
Compare
neheb
reviewed
Oct 18, 2025
neheb
reviewed
Oct 18, 2025
Member
|
Will merge in a week if there are no objections. |
bonzini
reviewed
Dec 24, 2025
| meson.override_dependency('absl_container', absl_container_dep) | ||
| meson.override_dependency('absl_flags', absl_flags_dep) | ||
| meson.override_dependency('absl_log', absl_log_dep) | ||
| meson.override_dependency('absl_status', absl_status_dep) |
|
Looks good, with just an aesthetic comment that you can disregard too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
tracing.cctoabsl_base_sources, and adds tests for base, numeric, hash, crc32, container, and logging to try and catch any other missing sources.