JoltPhysics: Add wrap for 5.3.0 #2410
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache-hb
force-pushed
the
jolt-5.3.0
branch
from
fb8c5c8 to
afaf2b2
Compare
apache-hb
force-pushed
the
jolt-5.3.0
branch
from
afaf2b2 to
b7d2c6e
Compare
apache-hb
force-pushed
the
jolt-5.3.0
branch
6 times, most recently
from
330cf11 to
e2ea26b
Compare
Contributor
|
Can we get this pushed? |
bgilbert
reviewed
Dec 15, 2025
| # fine. | ||
| if cpp.get_id() == 'clang' and host_machine.system() == 'windows' | ||
| error( | ||
| 'unsupported architecture: Clang on cygwin/msys2 cannot build jolt due to linking issues, sorry', |
Collaborator
There was a problem hiding this comment.
This is technically an abuse of unsupported architecture, but indeed we don't have a separate disable flag for this.
What are the linking issues? Is it an upstream bug? Wrap bug?
Contributor
Author
There was a problem hiding this comment.
I honestly can't remember, I think it may have been a clang bug at the time
Collaborator
There was a problem hiding this comment.
We don't require CI to be completely green. If this isn't a known unfixable problem for some reason, it might be better to remove the check to avoid hiding the issue.
apache-hb
force-pushed
the
jolt-5.3.0
branch
3 times, most recently
from
c4449dc to
d4ce448
Compare
bgilbert
reviewed
Dec 16, 2025
| option( | ||
| 'cross_platform_determinism', | ||
| type: 'boolean', | ||
| value: true, |
apache-hb
force-pushed
the
jolt-5.3.0
branch
3 times, most recently
from
292e058 to
e66f470
Compare
apache-hb
force-pushed
the
jolt-5.3.0
branch
from
e66f470 to
dea985c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a wrap for the physics library Jolt Physics