Canned Messages via InkHUD menu #7096
Conversation
Ground work for CannedMessage getters and setters
Use the new AdminModule_ObserverData struct
Handles loading and parsing. Handle admin messages for setting and getting.
Allows us to intercept locally generated packets ('loopbackOK = true'), to handle outgoing canned messages.
|
Something's gone weird with the rebase, one minute |
Wasn't critical in ths specific case, but definitely a mistake.
|
Ahh, didn't have the CI holding my hand on the unify-tft branch, so hadn't noticed that the changes were upsetting the BaseUI builds. I think it's all sorted now. |
|
Hi @todd-herbert, I am not sure if this is the right platform, but is it possible to get this build for T-Echo INKHud, as the canned message is the exact feature I need now. Thank you! and sorry for any inconvenience caused. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality for sending canned messages via the InkHUD menu while integrating with the AdminModule’s observer system. Key changes include updating AdminModule’s observable data type to a custom structure, implementing a new CannedMessageStore for loading and parsing canned messages, and extending several InkHUD-related modules (MenuApplet, Events, ThreadedMessageApplet, and Screen) to support selecting and sending canned messages.
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/AdminModule.{h,cpp} | Updated observable type to AdminModule_ObserverData and refined logging. |
| src/main.cpp | Adjusted preprocessor condition to include canned message logic. |
| src/graphics/niche/Utils/CannedMessageStore.{h,cpp} | Introduced a new self-contained store for canned messages with loading and admin API support. |
| src/graphics/niche/InkHUD/{Persistence.h,Events.{h,cpp}} | Updated admin message callbacks to use AdminModule_ObserverData. |
| src/graphics/niche/InkHUD/Applets/{ThreadedMessage,MenuApplet}.{h,cpp} | Integrated canned message handling into UI applets and menu pages. |
| src/graphics/Screen.{h,cpp} | Adjusted admin message handling to support the new observer data structure. |
|
@Planktonicker looks like Ben has sorted it (Thanks!). |
3 participants
Adds canned messages to InkHUD's on-screen menu, without disturbing existing CannedMessageModule code.
Rebases #7077 against master. I had previously been advised that this PR should be made against the unify-tft branch, but it seems like the work there is now complete (#6838).
🤝 Attestations