Skip to content

Clean up install & update shell scripts #6839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roens
Copy link

@roens roens commented May 18, 2025

Clean up install & update shell scripts

Fixed quoting of the FILENAME variable to work when the path of the passed argument contains a space. Also fixed syntactical issues called out by shellcheck in multi-condition if statements. This has been an issue for (at least) me for every install or update I've attempted, as I do not unnecessarily cd into the dir containing the downloaded release files. It's also good practice to quote variables to keep the shell from "globbing and word splitting" the value of the variable.

Also normalized indentation chars (was mix of tabs & spaces) and trailing whitespace.

In the attestations below, I've marked the nrf52840-based devices as "n/a" as these shell scripts are not used for updating them.

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631 n/a
    • Seeed Studio T-1000E tracker card n/a
    • Other (please specify below) n/a

@CLAassistant
Copy link

CLAassistant commented May 18, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Fixed quoting of the `FILENAME` variable to work when the path of the
passed argument contains a space. Also fixed syntactical issues called
out by `shellcheck` in multi-condition `if` statements.

Also normalized indentation chars (was mix of tabs & spaces) and
trailing whitespace.
@fifieldt fifieldt force-pushed the clean-up-installupdate-sripts branch from 153e0b4 to 3346c21 Compare May 26, 2025 21:41
@fifieldt
Copy link
Member

Thanks for your attention to detail!

Let's see if trunk is happy with the whitespace changes :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants