Clean up install & update shell scripts #6839
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up install & update shell scripts
Fixed quoting of the
FILENAME
variable to work when the path of the passed argument contains a space. Also fixed syntactical issues called out byshellcheck
in multi-conditionif
statements. This has been an issue for (at least) me for every install or update I've attempted, as I do not unnecessarilycd
into the dir containing the downloaded release files. It's also good practice to quote variables to keep the shell from "globbing and word splitting" the value of the variable.Also normalized indentation chars (was mix of tabs & spaces) and trailing whitespace.
In the attestations below, I've marked the nrf52840-based devices as "n/a" as these shell scripts are not used for updating them.
🤝 Attestations
RAK WisBlock 4631n/aSeeed Studio T-1000E tracker cardn/aOther (please specify below)n/a