-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Bug/6529 class static block syntax error #6561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6561 +/- ##
==========================================
- Coverage 3.88% 3.88% -0.01%
==========================================
Files 412 414 +2
Lines 43219 43240 +21
Branches 665 666 +1
==========================================
Hits 1678 1678
- Misses 41541 41562 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
37868dc
to
bf259ef
Compare
The latest updates on your projects. Learn more about Argos notifications ↗︎ Awaiting the start of a new Argos build… |
bbafc84
to
24d40cf
Compare
d851632
to
0bc8c4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
Have added some comments to discuss about.
Chrome <=94 is ~1% users, and released 4 years back, I'm not sure if disabling a feature is worth it for these users, as we use other features like I'd be much happier to approve the PR if we move both the changes in esbuild under the flag. ![]() ![]() CC @knsv @aloisklink |
530a6b1
to
011cb5d
Compare
PR updated,
Thanks for your help. |
46ced68
to
c93ec97
Compare
Co-authored-by: Sidharth Vinod <[email protected]>
97d32ec
to
86319ce
Compare
📑 Summary
Brief description about the content of your PR.
--supported
flag to disable class static block syntax Resolves version 11 not work < chrome 94 #6529--target
flag to support customizable build to solve compatibility issues. Related to config: Compatible with low-version browsers. #6458--source-map
config to disable source map📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
esbuild
treat inline target option and compilerOptions.target option in tsconfig.json differently, tsconfig.json won't work as expected, so added target field to build options to specify language syntaxvite build
deprecated, remove ./vite/build.ts to reduce confusion📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.