Skip to content

[WC-2976] fix-warnings #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WC-2976] fix-warnings #1747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc21173
fix: prevent false positive warnings on empty editor trace
iobuhov Jul 2, 2025
4122cca
fix: change how editor state initialized
iobuhov Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions ...luggableWidgets/custom-chart-web/src/__tests__/__snapshots__/mergeChartProps.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`mergeChartProps utility function Data merging behavior should only process traces that exist in chart props 1`] = `[]`;

exports[`mergeChartProps utility function Data merging behavior should preserve original trace data when editor state has missing or falsy entries 1`] = `[]`;

exports[`mergeChartProps utility function Edge cases should handle empty chart props data 1`] = `[]`;

exports[`mergeChartProps utility function Edge cases should handle falsy values in editor state data without warnings 1`] = `[]`;

exports[`mergeChartProps utility function Edge cases should handle null JSON parsing 1`] = `[]`;

exports[`mergeChartProps utility function Edge cases should handle various malformed JSON types 1`] = `
[
[
"Editor props for trace(1) is not a valid JSON:{invalid json}",
],
[
"Please make sure the props is a valid JSON string.",
],
[
"Editor props for trace(3) is not a valid JSON:undefined",
],
[
"Please make sure the props is a valid JSON string.",
],
]
`;

exports[`mergeChartProps utility function JSON parsing failures generate console warnings should handle mixed valid and invalid JSON 1`] = `
[
[
"Editor props for trace(1) is not a valid JSON:invalid json",
],
[
"Please make sure the props is a valid JSON string.",
],
]
`;

exports[`mergeChartProps utility function JSON parsing failures generate console warnings should not warn for valid JSON 1`] = `[]`;

exports[`mergeChartProps utility function JSON parsing failures generate console warnings should not warn when editor state has undefined entries 1`] = `[]`;

exports[`mergeChartProps utility function JSON parsing failures generate console warnings should warn for invalid JSON in editor state data 1`] = `
[
[
"Editor props for trace(0) is not a valid JSON:invalid json",
],
[
"Please make sure the props is a valid JSON string.",
],
]
`;

exports[`mergeChartProps utility function JSON parsing failures generate console warnings should warn for multiple invalid JSON entries 1`] = `
[
[
"Editor props for trace(0) is not a valid JSON:invalid json",
],
[
"Please make sure the props is a valid JSON string.",
],
[
"Editor props for trace(1) is not a valid JSON:{broken: json}",
],
[
"Please make sure the props is a valid JSON string.",
],
]
`;
Loading
Loading