[WC-2989]: custom chart data and layout parsing issue #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulivan
previously approved these changes
Jul 1, 2025
iobuhov
reviewed
Jul 2, 2025
There was a problem hiding this comment.
Indeed, this one also should close issue WC-2976. But to make sure we don't have same issue again I we need unit tests for this utils. We need make sure there is no "false-pasitive" warnings.
If you can please use spy on console and add few basic tests. Also we probably need to cover cases with empty strings.
samuelreichert
force-pushed
the
fix/WC-2989-chart-static-sample-data-issue
branch
from
364fd72 to
64bb8b4
Compare
leonardomendix
previously approved these changes
Jul 4, 2025
gjulivan
approved these changes
Jul 4, 2025
leonardomendix
approved these changes
Jul 4, 2025
…en attribute is empty
…d parseConfig functions
gjulivan
force-pushed
the
fix/WC-2989-chart-static-sample-data-issue
branch
from
066237c to
d457541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description