Skip to content

Conversation

@m-gorecki
Copy link
Contributor

@m-gorecki m-gorecki commented Dec 18, 2025

This:

  1. Removes a variable with external linkage which is only used in imgmgr but it's never set anywhere so it's always 0.
  2. Makes bootutil_public.c the only source file built for non-bootloader builds, so we don't have to set bootutil syscfgs that are relevant only to the bootloader when building an application.

@de-nordic de-nordic added the area: mbed Affects mbed platform label Dec 18, 2025
Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate commits for embed and bootutil changes

@m-gorecki
Copy link
Contributor Author

@de-nordic Could you please explain how this affects mbed platform? This only modifies files from bootutil package

@de-nordic de-nordic added area: mynewt and removed area: mbed Affects mbed platform labels Dec 18, 2025
@de-nordic
Copy link
Collaborator

de-nordic commented Dec 18, 2025

@de-nordic Could you please explain how this affects mbed platform? This only modifies files from bootutil package

Sorry, my bad. mynewt then. Common and platform/system specific files are touched in single commit.

This removes a variable with external linkage which is only used
in imgmgr but it's never set anywhere so it's always 0.

Signed-off-by: Michal Gorecki <[email protected]>
This makes bootutil_public.c the only source file built for
non-bootloader builds, so we don't have to set bootutil syscfgs
that are relevant only to the bootloader when building
an application.

Signed-off-by: Michal Gorecki <[email protected]>
@m-gorecki m-gorecki changed the title boot/bootutil: Imporve mynewt BOOTUTIL configuration bootutil: mynewt: Imporve BOOTUTIL configuration Dec 19, 2025
@nordicjm nordicjm requested a review from de-nordic December 19, 2025 10:36
@nordicjm nordicjm merged commit e015209 into mcu-tools:main Dec 23, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants