#262: Adding "test" mode for the Fakes to get generated intot he same package #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
counterfeiter to generate fakes in the same package in the _test.go files, so in case the interface is defined in the same package where it is used there won't be circular dependency.
…y, in case fakes are generated into the same package's _test.go file.
Ensured that '-t' option is not mixed up with '-p' or '-o'. Revering io.Discard back to ioutil.Discard as it is irrelevant to this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue #262.
The idea here is that a new argument '-t' is getting introduced which is mutually exclusive with '-p' and '-o' as it is generates fake implementation to the same package into the
_test.gopackage.