Skip to content

insert local config file path to config file page#24214

Merged
sgiehl merged 9 commits into5.x-devfrom
dev-17366
Mar 17, 2026
Merged

insert local config file path to config file page#24214
sgiehl merged 9 commits into5.x-devfrom
dev-17366

Conversation

@nathangavin
Copy link
Contributor

@nathangavin nathangavin commented Mar 12, 2026

Description

Fixes #21478

Admin > Diagnostic > Config file page currently has a hardcoded value for the config file path. This change instead uses the local path of the instance config file.

Checklist

  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

Review

@nathangavin nathangavin added this to the 5.9.0 milestone Mar 12, 2026
@nathangavin nathangavin requested a review from a team March 13, 2026 02:08
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A UI test is failing. Looks a bit strange, that the path now starts with //. Might be good to check the reason instead of simply updating the screenshot.

@nathangavin
Copy link
Contributor Author

A UI test is failing. Looks a bit strange, that the path now starts with //. Might be good to check the reason instead of simply updating the screenshot.

Looks like the PIWIK_USER_PATH is being set to var/www/html/ (test/PHPUnit/proxy/includes.php), so when the config file path is generated, you get a double slash var/www/html//config/config.ini.php. Somewhere in the tests that first section is removed from paths in UI tests, so you end up with //config/config.ini.php. I've updated the logic such that PIWIK_USER_PATH is set to var/www/html in tests, so we end up with a path with the correct slashes. The only side-effect of this change is the fact that PIWIK_USER_PATH is no longer considered custom, so the Diagnostic UI screenshot needed updating too.

@nathangavin nathangavin requested a review from sgiehl March 16, 2026 05:38
@nathangavin nathangavin requested a review from sgiehl March 16, 2026 22:18
@sgiehl sgiehl merged commit b3cb519 into 5.x-dev Mar 17, 2026
31 checks passed
@sgiehl sgiehl deleted the dev-17366 branch March 17, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Show path to config file in Diagnostic -> Config file screen

3 participants