Fix DevicesDetection User-Agent double escaping#23977
Merged
sgiehl merged 1 commit intomatomo-org:5.x-devfrom Jan 19, 2026
Merged
Fix DevicesDetection User-Agent double escaping#23977sgiehl merged 1 commit intomatomo-org:5.x-devfrom
sgiehl merged 1 commit intomatomo-org:5.x-devfrom
Conversation
- Replace deprecated Common::getRequestVar with Request class - Use raw string from request to prevent double escaping in Twig templates Signed-off-by: letmefixthis <letmefixthis.code@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reproduce:
Go to the "Devices Detection" admin tool (index.php?module=DevicesDetection&action=detection).
Enter a double quote " in the User-Agent field and click the [Update] button.
Result: The output field shows the HTML entity " instead of the literal " character.
Checklist
Review