Invalidate sessions created by inactive plugins#23966
Closed
nathangavin wants to merge 17 commits into5.x-devfrom
Closed
Invalidate sessions created by inactive plugins#23966nathangavin wants to merge 17 commits into5.x-devfrom
nathangavin wants to merge 17 commits into5.x-devfrom
Conversation
nathangavin
added
Needs Review
c: Security
sgiehl
requested changes
Jan 20, 2026
Member
sgiehl
left a comment
sgiehl
left a comment
There was a problem hiding this comment.
Left some comments for code improvements.
Besides that we should also ask @matomo-org/plugin-reviewers for a review / test, to ensure it solves the issue we are trying to solve with it.
sgiehl
reviewed
Jan 21, 2026
sgiehl
reviewed
Jan 21, 2026
sgiehl
reviewed
Jan 21, 2026
sgiehl
reviewed
Jan 21, 2026
Contributor
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
I tested this PR against LoginLdap and LoginSaml plugin, and on plugin deactivation, the user was asked to sign-in again.
Contributor
Author
|
Closed due to alternate solution being implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Checklist
Review