Skip to content

FNO battery module cooling example #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bwdGitHub
Copy link
Collaborator

No description provided.

@bwdGitHub bwdGitHub requested a review from conordaly0 June 19, 2025 10:24
Copy link
Member

@conordaly0 conordaly0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben!

It would be good to put something more visual in the README -- especially since the main live script will not be viewable on GitHub.

## Requirements

Requires
- [MATLAB](https://www.mathworks.com/products/matlab.html) (R2025a or newer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this run in earlier releases? What 25a features are requied?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK the example states we're using 25a functionality to handle the geometry.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the helper function in this example should work in some older releases than 25a. I'm not sure what the most recent Deep Learning Toolbox code I've used is, maybe the networkLayer from 24a, though it isn't strictly necessary. The PDE Toolbox introduced the femodel in 23a, but there was ThermalModel before that which might suffice for this example. So potentially we could write a version of the example that's supported quite a few releases back.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old APIs like ThermalModel will eventually be removed, so I would strongly suggest staying with femodel (23a as Ben mentioned)

…d files, add images in the resources sub-directory
@bwdGitHub
Copy link
Collaborator Author

Thanks Ben!

It would be good to put something more visual in the README -- especially since the main live script will not be viewable on GitHub.

I've added a bunch more detail and a few images now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants