Open
Conversation
Owner
|
Hey @finngreig, that's a great addition! Thank you for your contribution. I would add 2 points:
This is the most challenging part of ng-tw, I'm still thinking of a unified way to control that, for now I'm adding ways to handle that inside each component.
|
Author
|
Hey @matheusdavidson - sounds good - I'll look into adding colour controls like that, and I'll also decouple the toggle. I'll keep this PR for the checkbox and put the toggle on a new one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Matheus,
Here's a checkbox component we've made - let us know if there's any changes you need :)
GIF for reference: