Skip to content

Checkbox/toggle component#15

Open
finngreig wants to merge 7 commits intomatheusdavidson:masterfrom
octalnz:ng-tw-checkbox
Open

Checkbox/toggle component#15
finngreig wants to merge 7 commits intomatheusdavidson:masterfrom
octalnz:ng-tw-checkbox

Conversation

@finngreig
Copy link
Copy Markdown

Hey Matheus,

Here's a checkbox component we've made - let us know if there's any changes you need :)

GIF for reference:

Screenshot GIF

@matheusdavidson
Copy link
Copy Markdown
Owner

Hey @finngreig, that's a great addition! Thank you for your contribution.

I would add 2 points:

  1. We need to find a way to let the user control colors, having default ones and option to change, something like was done in other components like button and progress-bar. I think for this one would make sense a smaller implementation like in progress-bar, maybe having colors for selected and deselected, what do you think?

This is the most challenging part of ng-tw, I'm still thinking of a unified way to control that, for now I'm adding ways to handle that inside each component.

  1. I think we should decouple toggle from checkbox since they might have different implementations and use cases in the future, but this can be done in another time in near future.

@finngreig
Copy link
Copy Markdown
Author

Hey @matheusdavidson - sounds good - I'll look into adding colour controls like that, and I'll also decouple the toggle. I'll keep this PR for the checkbox and put the toggle on a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants