fix(docs): add autocomplete=off to homepage input demos to prevent Firefox password autofill#8688
Open
pierreeurope wants to merge 1 commit intomantinedev:masterfrom
Open
Conversation
…refox password autofill Firefox incorrectly identifies PasswordInput and ColorInput in homepage demos as login fields, triggering the password manager popup when navigating from mantine.dev to the Getting Started page. Adding autoComplete='off' to the shared inputProps prevents Firefox from offering to save/fill passwords for these decorative demo inputs. Fixes mantinedev#8682 Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=956906
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8682
Firefox identifies
PasswordInputandColorInputin the homepage component demos as login fields, triggering the password manager popup when navigating frommantine.devto the Getting Started page.Changes
Added
autoComplete: 'off'to the sharedinputPropsobject inHomePageInputsDemo.tsx. This is a one-line change that applies to all demo inputs on the homepage, preventing Firefox from offering to save/fill passwords for these decorative demo inputs.Root Cause
Firefox password manager heuristics (see Mozilla Bug 956906) detect
<input type="password">elements on the page and assume they are part of a login form, even when they are just component demos. Theautocomplete="off"attribute tells the browser these inputs are not login-related.Testing