[@mantine/core] Checkbox: Add aria-describedby support for error and description (#8340)#8526
Open
hlongc wants to merge 1 commit intomantinedev:masterfrom
Open
[@mantine/core] Checkbox: Add aria-describedby support for error and description (#8340)#8526hlongc wants to merge 1 commit intomantinedev:masterfrom
hlongc wants to merge 1 commit intomantinedev:masterfrom
Conversation
Contributor
|
I have tested this PR and it does in fact fix the problem, without the PR, the error messages are not read by mac voice over. |
Member
|
Thanks for validation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #8340
Checkbox error messages are now accessible to screen readers like VoiceOver. Previously, the error and description text were not announced when focusing on the checkbox input.
Changes
aria-describedbyattribute to checkbox input elementdescriptionIdanderrorIdpropsHow it works
When a Checkbox has an error or description:
aria-describedbyThis ensures screen readers properly announce the description and error messages when users focus on the checkbox.
Testing
All tests pass (54/54):
Tested with Mac VoiceOver - error messages are now properly announced. 🎉