Skip to content

fix(api): fall back to WEB_URL when Redis origin key is missing (#9354) #9361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reachsanjivbhagat-gif wants to merge 1 commit into
base: preview
Choose a base branch
from
+6 −2
Open

fix(api): fall back to WEB_URL when Redis origin key is missing (#9354) #9361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/api/plane/bgtasks/email_notification_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

# Django imports
from django.utils import timezone
from django.conf import settings

# Module imports
from plane.db.models import EmailNotificationLog, Issue, User
Expand Down Expand Up @@ -163,9 +164,12 @@ def send_email_notification(issue_id, notification_data, receiver_id, email_noti
ri = redis_instance()
base_api = ri.get(str(issue_id)).decode() if ri.get(str(issue_id)) else None

# Skip if base api is not present
# Fall back to the configured web URL if the cached origin is missing
if not base_api:
return
logging.getLogger("plane.worker").warning(
f"Redis origin key missing for issue {issue_id}; falling back to WEB_URL for email notification links"
)
base_api = settings.WEB_URL

data = create_payload(notification_data=notification_data)

Expand Down